i18n: removed strings generated with scanner #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i18next scanner - has some issue while extracting messages only if the strings are marked with |
Closed
zzacharo
reviewed
Jul 19, 2021
There was a problem hiding this comment.
@mb-wali what about adding here the https://github.com/i18next/react-i18next-gitbook/blob/master/latest/i18nextprovider.md#when-to-use as it this is the component library and leave the global context i.e the default one, in the inveniosoftware/invenio-app-rdm#978 ?
| @@ -23,6 +24,9 @@ const options = { | |||
| // cache user language off | |||
| caches: [], | |||
| }, | |||
| react: { | |||
| transKeepBasicHtmlNodesFor: [], | |||
There was a problem hiding this comment.
Maybe a comment on why is this needed?
mb-wali
force-pushed
the
i18n-bugs
branch
4 times, most recently
from
55c2a82
to
f17eb24
Compare
zzacharo
force-pushed
the
i18n-bugs
branch
3 times, most recently
from
e700620
to
4fc0098
Compare
* Adds german translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.