xrdfile: fixed reading part of file bigger than 2GB when file cursor set over 2GB. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pazembrz
added this to In progress
in Files bundle sprint (July 22 to Aug 2)
via automation
pazembrz
moved this from In progress
to Pending review
in Files bundle sprint (July 22 to Aug 2)
kpsherva
approved these changes
Jul 30, 2019
|
|
||
|
|
||
| def test_reading_begining_of_big_file(tmppath): | ||
| """Tests reading end of big file.""" |
There was a problem hiding this comment.
minor: code repetitions in the tests, could be reusable
xrootdpyfs/xrdfile.py
Outdated
| @@ -22,6 +23,8 @@ | |||
| from .utils import is_valid_path, is_valid_url, spliturl, \ | |||
| translate_file_mode_to_flags | |||
|
|
|||
| LOGGER = logging.getLogger(__name__) | |||
There was a problem hiding this comment.
I would keep logger as lowercase, for consistency with the rest of the code
lnielsen
reviewed
Jul 30, 2019
xrootdpyfs/xrdfile.py
Outdated
| chunksize = sizehint if sizehint > 0 else self.size - self._ipp | ||
|
|
||
| if chunksize >= 2147483648: # 2GB in bytes | ||
| LOGGER.warning( |
There was a problem hiding this comment.
Is the logging necessary here? I mean the library is going to throw an OverFlowError if you pass beyond the limit. Also, as far as I remember, I did some tests, and it's not exactly 2GB the limit for some reason.
Either we just say that chunksizes >X get set to X so that the read will succeed....alternativelty, we throw an error
lnielsen
moved this from Pending review
to In progress
in Files bundle sprint (July 22 to Aug 2)
…set over 2GB. Docker update for tests not to fail as last working xrootd is 4.7.1. closes: inveniosoftware#85
pazembrz
moved this from In progress
to Pending review
in Files bundle sprint (July 22 to Aug 2)
Files bundle sprint (July 22 to Aug 2)
automation
moved this from Pending review
to Done
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally dockerfile update for tests not to fail as last working xrootd is 4.7.1.
closes: #85