Replace alias_method_chain with alias_method to be compatible with Rails >= 5.1 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alias_method_chain has been deprecated and removed in rails 5.1
(see: rails/rails#27035)
Apparently, defining methods such as :a_with_b and :a_without_b used to be a
common pattern in rails, so alias_method_chain was introduced to encapsulate
this (see: https://apidock.com/rails/ActiveSupport/CoreExtensions/Module/alias_method_chain).
Here is an example of how this works and how we can replace
alias_method_chain with alias_method:
It is necessary to replace alias_method_chain because we use this gem in the
inventables/fbolt repo, and it may take some time to rewrite fbolt such that
this gem is no longer be a dependency.
Meanwhile, we are encountering deprecation warnings which are quite noisy.
Before upgrading from rails 5.0 to 5.1, we will have to address each of the
dependencies that still use alias_method_chain.
This article was also helpful: https://littlelines.com/blog/2018/01/31/replace-alias-method-chain