Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable open groups #456

Closed
jum-s opened this issue Nov 16, 2020 · 3 comments
Closed

Enable open groups #456

jum-s opened this issue Nov 16, 2020 · 3 comments

Comments

@jum-s
Copy link
Contributor

jum-s commented Nov 16, 2020

Like mobilizon recently did, group settings would have an option to pick if the group is open to new members or on invite only (like today's implementation).

Default would be on invite.
In case of an open group, there would be no request process, users would become member when pressing "Join the group" (today named "Request to join the group").

@maxlath
Copy link
Member

maxlath commented Nov 18, 2020

Some thoughts:

  • I imagine that open groups will strenghten the need for finer visibility settings: having no way to show certain items or shelves to friends but not to members of an open group is getting very sub-optimal. That basically mean that as long as you are part of an open group, I can unilaterally decide to see as much of your inventory as your friends.
  • [applies to non-open groups, but might be more critical on open groups] Should we set a maximum number of members? That can wait but I guess we might experience performance issues in both the server and client with very large groups.
  • We will need some UI elements to make those settings (open but also searchable) known to people before they join a group
  • Changes on those settings by a group admin should ideally trigger a notification for all members (just like we already have a notification for group name or description changes)

@jum-s
Copy link
Contributor Author

jum-s commented Jan 1, 2021

i agree on the notification part.
I will work on the ui, im thinking of triggering an alert modal when clicking on the "join group" button. A text that could say "since this group is open, every users can freely join this group and see your items which have a "friends and groups" sharing settings. Would you like to continue and join this group ?"
On the visibility settings, i think that's par of other issues. Same for the maximum group member (which we could setup when the server is too stressed ?)

@maxlath
Copy link
Member

maxlath commented Feb 10, 2021

done in #460 and inventaire/inventaire-client#240

@maxlath maxlath closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants