get_bnf_entry_from_isbn: add edition contributors #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jum-s
reviewed
Mar 29, 2023
| @@ -6,7 +6,7 @@ import { forceArray } from '#lib/utils/base' | |||
| import getInvEntityCanonicalUri from '../get_inv_entity_canonical_uri.js' | |||
| import properties from '../properties/properties_values_constraints.js' | |||
|
|
|||
| export default async (claims, resolveOnWikidata = true) => { | |||
| export async function resolveExternalIds (claims, resolveOnWikidata = true) { | |||
There was a problem hiding this comment.
ah thx for that, much more greppable with named function
jum-s
reviewed
Mar 29, 2023
| export async function setEditionContributors (edition, property, urls) { | ||
| const uris = await resolveContributors(urls) | ||
| if (uris.length > 0) { | ||
| edition.claims[property] = uris |
There was a problem hiding this comment.
There is a common pattern of seeds sometimes assigning translators as P50. But this will not conflict with the possibility of already having those authors in the P50 claim, right? aka BNF based entity creation is not based on the seed, right?
There was a problem hiding this comment.
That should not conflict, as far as I can tell
|
wanted to rebase and merge, but tests need a functionnal BNF API which is not the case at the moment |
jum-s
approved these changes
Sep 25, 2023
maxlath
force-pushed
the
add-edition-contributors-to-bnf-seeds
branch
from
47bdd22
to
9b7a98e
Compare
maxlath
force-pushed
the
add-edition-contributors-to-bnf-seeds
branch
from
9b7a98e
to
80cf9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely: translators, preface and postface authors