Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Task reorganise deduplicates #735

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Commits on Feb 28, 2024

  1. rename endpoints to reflect deduplicates specific actions

    namely:
      check_entities -> check_human_duplicates
      check_entity.js -> check_human_duplicate
      collect_entities -> collect_human_duplicates
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d8f558e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    309cdd8 View commit details
    Browse the repository at this point in the history
  3. add a task type parameter

    laying ground for "delete" type tasks
    
    this also renames the current "type" parameter to "entitiesType", this naming was here to avoid taking a decision about multi-words request parameters
    
    this commit chose camel case, but next commit is the alternative kebab possibility
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    72e246c View commit details
    Browse the repository at this point in the history
  4. have kebab case request parameter entities-type

    since actions are already using kebab
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c8ef10a View commit details
    Browse the repository at this point in the history
  5. tests fixtures refactor: improve fixture usage by returning task docu…

    …ment
    
    not only `{ "ok": true }`
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    261e7d7 View commit details
    Browse the repository at this point in the history
  6. tests refactor: improve tests solidity by mocking tasks creation

    since checkEntity has more complex results
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    dc098d6 View commit details
    Browse the repository at this point in the history
  7. do not create a autogenerated task if lexical score is too low

    threshold value is based on elastic score to create a defined amount of
    tasks.
    
    Its important to reject those suggestions after automerge, as a
    conservative feature to not automerge too many tasks only based on
    suggestions with a high lexical score, to not wrongly merge homonyms
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    97a0e89 View commit details
    Browse the repository at this point in the history
  8. allow to query human tasks via by-entities-type endpoint

    to be able to later create deduplicate human tasks
    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b981431 View commit details
    Browse the repository at this point in the history
  9. small renaming fix

    jum-s committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    17a458a View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    298bb58 View commit details
    Browse the repository at this point in the history
  2. get by-suspect-uris endpoint: use a byUriAndType dedicated couchview

    makes a reposability separation between hooks and endpoint. It keeps couch view keys simple (not having byUrisAndbyStateAndByType) while restricts the endpoint access to stateless (aka not arcchived) tasks. This is possible since the client does not need to access archived tasks for the moment, so the new couch view only returns non-archived tasks.
    jum-s committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6d4308e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    577f0ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9376755 View commit details
    Browse the repository at this point in the history
  5. rename endpoint by-suspect-uris -> by-uris

    which is currently not in use by the client, but leaving it since entity layout will actually reuse it to display its own related tasks one day
    jum-s committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    75f769a View commit details
    Browse the repository at this point in the history