Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Request #652

Closed
lookme2 opened this issue Feb 17, 2020 · 13 comments · Fixed by #1048
Closed

New Feature Request #652

lookme2 opened this issue Feb 17, 2020 · 13 comments · Fixed by #1048
Labels
enhancement This is an suggested enhancement or new feature help wanted Assistance required part Related to Part models starter Good issue for a developer new to the project

Comments

@lookme2
Copy link

lookme2 commented Feb 17, 2020

I have been adding parts to InvenTree. I use Molex connectors often and I think it would be nice to be able to link two or more parts together. Like for example the Molex connector with the crimp pin.

@a7hybnj2
Copy link

Yea, a “related part”, “associated part” would be nice. I think you could do this in the short term by putting it in the notes or if you wanted to mess with it you could have a “crimped molex” part that is a build of the conn + pins parts

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature part Related to Part models labels Apr 22, 2020
@SchrodingersGat SchrodingersGat added help wanted Assistance required starter Good issue for a developer new to the project labels Sep 5, 2020
@eeintech
Copy link
Contributor

@lookme2 @a7hybnj2 In pursuit of this feature, I've created #1048

Please take a look and let me know if that looks like what you expected.

@lookme2
Copy link
Author

lookme2 commented Oct 19, 2020

@eeintech this looks great. I'll try to pull that down and give it a try sometime this week.

@sintech
Copy link
Contributor

sintech commented Oct 19, 2020

Static linking is good, but what about dynamic(automatic) linking?

For example 74-series ICs of different types have the same logic inside: 7400, 73LS00, 74ALS00, 74HC00. It would be nice if all variants of 74*00 were displayed as variant of each other.
Another example: in Russia we have variants of 74-series under different name 7400=К155ЛА3, 74LS00=К555ЛА3, etc.

I'm thinking about dynamic links based on regexp or match table.
Does that make sense?

@eeintech
Copy link
Contributor

@sintech For your example I suggest you use Part "Variants", see documentation.

If you want to automate variant creation, I suggest you take a look into the API and/or the Python Interface.
I do believe the logic driving "links" between parts should reside outside of InvenTree.

@eeintech
Copy link
Contributor

@lookme2 Were you able to try it? Any feedback?

@lookme2
Copy link
Author

lookme2 commented Oct 28, 2020

@eeintech sorry I have not. I've been very busy the last couple of weeks. I'll try to take a look by the end of the week.

@lookme2
Copy link
Author

lookme2 commented Oct 30, 2020

@eeintech I did a git pull this morning and I don't see the related parts tab. Is there something I need to setup for that?

@eeintech
Copy link
Contributor

@lookme2 Which branch did you pull?

@lookme2
Copy link
Author

lookme2 commented Oct 30, 2020

@eeintech The Master branch

@eeintech
Copy link
Contributor

@lookme2 Ha it's not in master yet.

Try this:

$ git remote add eeintech https://github.com/eeintech/InvenTree.git
$ git fetch eeintech
$ git checkout -b related_parts
$ git pull eeintech related_parts

@lookme2
Copy link
Author

lookme2 commented Nov 2, 2020

@eeintech I had a chance to look at this over the weekend. Very nice. Thanks!!!

@eeintech
Copy link
Contributor

eeintech commented Nov 2, 2020

@lookme2 Glad to hear! I'll ask @SchrodingersGat to review and merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature help wanted Assistance required part Related to Part models starter Good issue for a developer new to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants