Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to hide related parts #1734

Merged
merged 1 commit into from Jun 29, 2021
Merged

option to hide related parts #1734

merged 1 commit into from Jun 29, 2021

Conversation

matmair
Copy link
Member

@matmair matmair commented Jun 29, 2021

Fixes #1733

@SchrodingersGat SchrodingersGat merged commit 8ee12ab into inventree:master Jun 29, 2021
@SchrodingersGat
Copy link
Member

Thanks!

@matmair matmair deleted the hide-related branch June 29, 2021 11:25
@eeintech
Copy link
Contributor

@matmair @SchrodingersGat Do we actually want to keep this feature? I would say yes, we're using it lightly and was requested in #652 and implemented in #1048 but if all those "niche" features are clogging InvenTree I don't think we should keep them..?

@SchrodingersGat
Copy link
Member

I'm happy to keep it for now. Minimal effort to keep it hidden - perhaps it should be the default?

@eeintech
Copy link
Contributor

I'm okay with hidden as default, made me realize the "documentation" is buried in release notes: https://inventree.readthedocs.io/en/latest/releases/0.1.4/#related-parts

@lookme2
Copy link

lookme2 commented Jun 29, 2021

I use it pretty heavily here at my place. I vote to keep it.

@matmair
Copy link
Member Author

matmair commented Jun 29, 2021

Maybe we should make it a bit more visible in the docs.

I personally do not use this feature very much and have no strong feelings on how the default should be, just implemented the PR because I had some spare time after lunch.

@SchrodingersGat SchrodingersGat mentioned this pull request Jun 29, 2021
Closed
SchrodingersGat added a commit to inventree/inventree-docs that referenced this pull request Jul 3, 2021
@SchrodingersGat
Update 0.2.5.md
7899771 
- inventree/InvenTree#1736
- inventree/InvenTree#1750
- inventree/InvenTree#1744
- inventree/InvenTree#1731
- inventree/InvenTree#1734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to hide "related parts" tab
4 participants
@matmair @SchrodingersGat @eeintech @lookme2