Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange simplification #1611

Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented May 27, 2021

Simplification of currency exchange rates.

Ref: #1482

@SchrodingersGat
Copy link
Member Author

@matmair @eeintech this PR represents somewhat of a regression in terms of functionality, but the way that currency exchange works now has been greatly simplified.

The currency "settings" view now looks like this:

image

Notes:

  • There is no facility to manually edit exchange rate data (this will be added back in later after more of a case study)
  • Currency settings are now reverted to being configured in the settings file rather than database settings (to work more cleanly with django-money)
  • Simple button to "update now"

@SchrodingersGat SchrodingersGat merged commit 59aca27 into inventree:master May 27, 2021
@SchrodingersGat SchrodingersGat deleted the exchange-simplification branch May 27, 2021 07:10
@eeintech
Copy link
Contributor

Thanks for the quick fix @SchrodingersGat

Minor things but worth mentioning:

  • Changing the base currency in the config.yaml does not reset the exchange rates (which could lead to erroneous conversions)
  • There is a leftover print here:
    print("POST!")

@SchrodingersGat
Copy link
Member Author

Thanks @eeintech - #1612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants