Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically switch between navbar selections on pages #1811

Merged
merged 35 commits into from Jul 15, 2021

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Jul 13, 2021

Loads all page content at once, and simply switches between the available elements.

As most data are loaded via the AJAX API anyhow, this is pretty performant.

Views to refactor:

  • Purchase Order
  • Sales Order
  • Build Order
  • Company
  • Part
  • PartCategory
  • StockItem
  • StockLocation
  • ManufacturerPart
  • SupplierPart

Other Tasks

  • Refactor "detail" view of Part page
  • Fix "BOM upload" form (in Part page)
  • Fix "PO Import" form (in PurchaseOrder page)
  • Fix "part pricing" view (in Part page)
  • Fix "import part" view (in PartCategory page)

Ref: #1683
Ref: #1673

@SchrodingersGat SchrodingersGat self-assigned this Jul 13, 2021
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature user interface User interface labels Jul 13, 2021
@SchrodingersGat SchrodingersGat merged commit bb60eed into inventree:master Jul 15, 2021
@SchrodingersGat SchrodingersGat deleted the spa branch July 15, 2021 13:43
@eeintech
Copy link
Contributor

@SchrodingersGat Got excited to try it out but having some weird issue on the "Part" view (I forced reload the page):

  1. Suppliers and Manufacturers tab are separated again, regression from Consolidate Manufacturers and Suppliers views #1793

image

  1. Suppliers and Manufacturers table are missing

image

image

  1. The CSS of the navbar shows a tab grey when active (aesthetic only)

image

@eeintech
Copy link
Contributor

eeintech commented Jul 15, 2021

Also I like that the "Details" tab is gone (that means simpler interface) but didn't you want the default Part view to follow #1808 and #1673 ?

@SchrodingersGat
Copy link
Member Author

Thanks for the quick review! New PR with some bug fixes

@eeintech eeintech mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants