New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically switch between navbar selections on pages #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchrodingersGat
added
enhancement
This is an suggested enhancement or new feature
user interface
User interface
labels
Jul 13, 2021
- refactor purchaseorder view - refactor salesorder view
- Also perform null check on notes before displaying
@SchrodingersGat Got excited to try it out but having some weird issue on the "Part" view (I forced reload the page):
|
Thanks for the quick review! New PR with some bug fixes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads all page content at once, and simply switches between the available elements.
As most data are loaded via the AJAX API anyhow, this is pretty performant.
Views to refactor:
Other Tasks
Ref: #1683
Ref: #1673