Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of purchaseorder line item table #2021

Merged
merged 1 commit into from Aug 25, 2021

Conversation

SchrodingersGat
Copy link
Member

  • Was conflicting with purchaseorder table
  • Saved column selections were being overridden

Fixes #1985

- Was conflicting with purchaseorder table
- Saved column selections were being overridden
@SchrodingersGat SchrodingersGat added the bug Identifies a bug which needs to be addressed label Aug 25, 2021
@SchrodingersGat
Copy link
Member Author

@eeintech the two tables in question had the same "name" - this name is used to store the column selections in your browser local storage.

Can you please test this and let me know if the issue is addressed?

SchrodingersGat added a commit to inventree/inventree-docs that referenced this pull request Aug 25, 2021
Copy link
Contributor

@eeintech eeintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda suspected those two tables were sharing the same local cache / same id or name. I'm glad you found this and yes it is working great now!

@SchrodingersGat SchrodingersGat merged commit 9b6b582 into inventree:master Aug 25, 2021
@SchrodingersGat SchrodingersGat deleted the table-col-fix branch August 25, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Purchase order tables options do not stick
2 participants