New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 5 #2205
Bootstrap 5 #2205
Conversation
- Still needs fixing in modal forms
@SchrodingersGat I tried to do this and esp. bootstrap tables does some wired stuff with bootstrap 5. Also, we probably need js-tree or something similar for the nice trees on the side. Testing this PR will be a challenge as there is a ton of js-code than ingests strings into the UI. Def something that is needed 👍 . |
@matmair absolutely this will be a tough one to test. I think it is worth the transition, though! |
- Update bootstrap classes and terminology - Visual tweaks to modal form title block
- Fix css classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should make the mobile / tablet experience a lot nicer
Already have done that throughout the process, there seem to be some problems with wrapping on upright iPads - will submit a PR to fix that |
Looks really nice by the way. Should we refactor the themes too? |
Yes, to both these things. Let's address these with separate PRs. |
@SchrodingersGat is it intentional that the treeview for parts and stock locations is not there anymore? I found that feature very handy. |
@matmair the "tree view" is now implemented in the subcategory and sublocation tables, like so: You can toggle this view in the top-right of the table: Does this meet your needs? The dedicated tree views could be added back in but I'd do it a different way now, the old method was very inefficient. |
@SchrodingersGat we should document any major UI shifts in the release notes so nobody gets confused |
@SchrodingersGat, sorry to intrude, but I also find this treeview very helpful for quick navigation. As a suggestion, what do you think about adding a drop-down list with part subcategories near the current breadcrumbs. In this way it will consume only one line of vertical screen space and you still be only one click away from any subcategory. |
@SchrodingersGat I am happy with the current solution. Just needed to be pointed to the filter. |
@SchrodingersGat, I have created new FR with mockups #2250. |
This PR upgrades bootstrap to v5.1.3
As the original bootstrap integration was kinda hacked-in, this implementation will be a lot more methodical and conformant to the bootstrap "standards".
(Read: Previously I had no idea what I was doing...)
Note: This will most likely be a long-running PR as there will be a lot of changes required...
Closes #2111
TODO
Refactor "table filters" UI (see comment below)(will leave for a separate PR)