Camera QR scanner #2779
Camera QR scanner #2779
Conversation
requirements.txt
Outdated
| @@ -24,6 +24,7 @@ django-mptt==0.11.0 # Modified Preorder Tree Traversal | |||
| django-redis>=5.0.0 | |||
| django-q==1.3.4 # Background task scheduling | |||
| django-sql-utils==0.5.0 # Advanced query annotation / aggregation | |||
| django-sslserver==0.22 # Secure HTTP development server | |||
There was a problem hiding this comment.
Pages have to be served over https in order to access the camera, so I needed a simple way to spin up a development server.
|
@rkalman ZXing went into maintenance mode so not relying on it would be nice. I took at the other library you suggested and it seems cool - what exactly did not work? Would you like me to take a look? |
|
I didn't spend too much time with it, but sometimes the camera stream didn't appear even on their demo page. |
|
@SchrodingersGat we should maybe look at this |
|
@rkalman looks like the camera integration works "out of the box" (at least for me)! Very impressive. Are there any features you still want to integrate, or is this ready for review? |
|
Please review it, thank you. |
|
@rkalman nice work!! Thank you |
|
@SchrodingersGat @rkalman if this merges (I hope so) there needs to be a license addition in the credits section |
| $('#barcode_scan_video_container').hide(); | ||
| } | ||
|
|
||
| function onBarcodeScanClicked(e) { |
There was a problem hiding this comment.
@rkalman you need to export this function in the exported section - so just add
onBarcodeScanClicked
in line 22 of this file
|
@rkalman looks good now 👍 |
|
Yes, thank you Mathias, I really had no idea why it is marked as unused... |
|
@rkalman we missed updating the number of rendered script files. It should really run through now - there are no more tests that should/can fail. |
|
@rkalman thanks for this great addition :) I'm happy to merge this in now. Can you please add a PR to the documentation which adds:
|
#1207
I understand the need of a general purpose scanner library, and recently html5-qrcode has gained 1D barcode functionality, however I have camera handling issues during testing. The zxing lib would be a great choice.
But if someone like to use a camera scanner with the internally generated QR codes only, maybe a lightweight solution like this is acceptable.