Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build output table improvements #2893

Merged
merged 30 commits into from Apr 29, 2022
Merged

Build output table improvements #2893

merged 30 commits into from Apr 29, 2022

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Apr 28, 2022 •
edited by gitpod-io bot

Significant overhaul of the "build output" screen:

  • Displays "completed tests" for each build output
  • Major speed improvement by optimizing API queries
  • Table is more "responsive" (does not reload the entire table on every action)

Example Page Load Speed Improvement

  • Old method: Approx. 6 seconds
  • New method: Approx. 3 seconds

(Using the same dataset)

Screenshot

image

Future Improvements

The API queries should still be optimized here, there are probably some other improvements that could be made to improve page load speed.

@SchrodingersGat SchrodingersGat marked this pull request as draft April 28, 2022 07:53
@SchrodingersGat SchrodingersGat self-assigned this Apr 28, 2022
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature user interface User interface api Relates to the API build Build orders labels Apr 28, 2022
@SchrodingersGat SchrodingersGat added this to the 0.7.0 milestone Apr 28, 2022
@SchrodingersGat
Allow completion of partially allocated build outputs
f531e35 
- Requires manual acceptance from user
@SchrodingersGat
Add a stock item transaction when installing items into a build output
b63352c
@SchrodingersGat
Refactor build page template
cb7c439 
- Only load build outputs table as required
@SchrodingersGat
Function to reload allocation table data
4a81c05
@SchrodingersGat
Row button fixes
df9a339
@SchrodingersGat
Update progress bars for build output allocation
6c6ebe7
@SchrodingersGat
Allow sorting of build output table by allocated items
3da6446
@SchrodingersGat
Refactor button callbacks
6e52ca2 
- Add button to expand all output rows
- Add button to collapse all output rows
@SchrodingersGat
Show or hide items based on output BOM
81638d0
@SchrodingersGat
Display error if stock item is "double allocted"
6b4592b
@SchrodingersGat
Adds ability to filter StockItemTestresult API list by Build ID
e0189be 
- Allows us to retrieve stock item test results in a single API query
@SchrodingersGat
Retrieve all stock item test results at once
a0ca20a
@SchrodingersGat SchrodingersGat marked this pull request as ready for review April 29, 2022 03:36
@SchrodingersGat SchrodingersGat merged commit 227b3d6 into inventree:master Apr 29, 2022
@SchrodingersGat SchrodingersGat deleted the build-output-table-improvements branch April 29, 2022 05:05
@eeintech
Copy link
Contributor

Sorry @SchrodingersGat did not have the chance to look it up, looks good in the demo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeintech eeintech Awaiting requested review from eeintech

@matmair matmair Awaiting requested review from matmair

Assignees

@SchrodingersGat SchrodingersGat

Labels
api Relates to the API build Build orders enhancement This is an suggested enhancement or new feature user interface User interface
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SchrodingersGat @eeintech