[FR] Refactor plugin registry #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matmair bumping this to the next release cycle |
|
@SchrodingersGat this would be ready for review. No change in functionality, just a refactor. |
This reverts commit aff17dd.
|
Should we break all mixins out into their own file, if we are doing some of them? |
|
@SchrodingersGat I only broke out the complex ones but I can do all integration mixins if you think it is better. Trying to keep my PRs more manageable in size ;-) |
Appreciated, it can be hard to keep up with larger PRs as the codebase evolves! I'll merge this in as-is for now, we can factor out others later as required. Thanks for the continued hard work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the (de)activation sequences for plugins out of the registry and into the mixins themselves. It also factors out the impacted plugins into their own files.
The main advantage of this is that mixin-specific parts are isolated in that mixins code. This makes tests more stable and possibly enables dynamic loading of mixins ie. mixins as plugins. The larger goal is to make core plugin code slimmer and simpler.
Fixes #4184