Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mklint with djlint #4746

Merged
merged 18 commits into from
May 2, 2023
Merged

Conversation

matmair
Copy link
Contributor

@matmair matmair commented May 1, 2023

This PR:

  • removes markuplint
  • removes the HTLM checker step
  • adds djlint to pre-commit
  • fixes the django templates to follow a clean code style; especially:
    • Endblocks should have a name
    • images should have names
    • cleans unneeded empty lines
    • fixes white spacing around variables

Fixes #4730

@matmair matmair added CI CI / unit testing ecosystem dependency Relates to a project dependency labels May 1, 2023
@matmair matmair added this to the 0.12.0 milestone May 1, 2023
@matmair matmair marked this pull request as draft May 1, 2023 21:07
@SchrodingersGat
Copy link
Member

This is a huge improvement :)

@matmair matmair self-assigned this May 2, 2023
@matmair matmair marked this pull request as ready for review May 2, 2023 05:47
@matmair
Copy link
Contributor Author

matmair commented May 2, 2023

@SchrodingersGat ready for merge; you will have to change the protection rules to remove the HTML check from the required checks as that no longer exists.

@SchrodingersGat SchrodingersGat merged commit 10c3d10 into inventree:master May 2, 2023
12 checks passed
@SchrodingersGat
Copy link
Member

THanks for the improvements @matmair

@matmair matmair deleted the matmair/issue4730 branch May 2, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem dependency Relates to a project dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Replace markuplint with djlint
2 participants