-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible fix for git messages #4882
Conversation
Let's hope so! Any luck so far? |
Do you think this line is also responsible for these messages? InvenTree/InvenTree/plugin/helpers.py Line 119 in 86b7254
|
@wolflu05 to a part - yes. Another big source was the lookup for commit number and date. |
Strangely enough, the tests no longer throw the error - bare metal still does. @SchrodingersGat this def makes things better. Let's merge this in and I will submit another PR once I have determined the rest comes from. |
So you won't add your check also to this usage of git in this PR? |
No, it broke in some tests with the check added. I need a better one for the packages. |
Very clever fix @matmair :) |
Not really TBH but thanks |
This PR might fix #4428