Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for git messages #4882

Merged
merged 6 commits into from
May 25, 2023

Conversation

matmair
Copy link
Contributor

@matmair matmair commented May 23, 2023

This PR might fix #4428

@matmair matmair added the setup Relates to the InvenTree setup / installation process label May 23, 2023
@matmair matmair added this to the 0.12.0 milestone May 23, 2023
@matmair matmair self-assigned this May 23, 2023
@matmair matmair changed the title Matmair/issue4428 Possible fix for git messages May 23, 2023
@SchrodingersGat
Copy link
Member

Let's hope so! Any luck so far?

@wolflu05
Copy link
Contributor

Do you think this line is also responsible for these messages?

output = str(subprocess.check_output(command, cwd=settings.BASE_DIR.parent), 'utf-8')[1:-1]

@matmair
Copy link
Contributor Author

matmair commented May 25, 2023

@wolflu05 to a part - yes. Another big source was the lookup for commit number and date.

@matmair matmair marked this pull request as ready for review May 25, 2023 18:38
@matmair
Copy link
Contributor Author

matmair commented May 25, 2023

Strangely enough, the tests no longer throw the error - bare metal still does. @SchrodingersGat this def makes things better. Let's merge this in and I will submit another PR once I have determined the rest comes from.

@wolflu05
Copy link
Contributor

wolflu05 commented May 25, 2023

@wolflu05 to a part - yes. Another big source was the lookup for commit number and date.

So you won't add your check also to this usage of git in this PR?

@matmair
Copy link
Contributor Author

matmair commented May 25, 2023

@wolflu05 to a part - yes. Another big source was the lookup for commit number and date.

So you won't add your check also to this usage of git in this PR?

No, it broke in some tests with the check added. I need a better one for the packages.

@SchrodingersGat
Copy link
Member

Very clever fix @matmair :)

@SchrodingersGat SchrodingersGat merged commit 717bb07 into inventree:master May 25, 2023
12 checks passed
@matmair
Copy link
Contributor Author

matmair commented May 25, 2023

Not really TBH but thanks

@matmair matmair deleted the matmair/issue4428 branch May 25, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple lines of "fatal: not a git repository (or any of the parent directories): .git" during update
3 participants