Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completeSalesOrderShipment typo in sales_order.js #4908

Merged
merged 1 commit into from May 26, 2023

Conversation

martonmiklos
Copy link
Contributor

Fixes #4906

@matmair matmair added bug Identifies a bug which needs to be addressed user interface User interface labels May 26, 2023
@matmair matmair added this to the 0.11.3 milestone May 26, 2023
@SchrodingersGat
Copy link
Member

Nice catch @martonmiklos - we really need to get some CI testing on the front end code ASAP

@SchrodingersGat SchrodingersGat merged commit 0b4a06a into inventree:master May 26, 2023
12 checks passed
@martonmiklos
Copy link
Contributor Author

Nice catch @martonmiklos -

Credits goes to @jelgersma

we really need to get some CI testing on the front end code ASAP

What is the plan for that (what technology do you prefer)?

@SchrodingersGat
Copy link
Member

What is the plan for that (what technology do you prefer)?

I don't really have enough knowledge about the unit testing frameworks available to make a call on that! Have to read some more. Can you make any recommendations?

@wolflu05
Copy link
Contributor

I would say some linting would be enough for the first, as there is anyway the plan to switch to react with typescript?

Linting, eg with eslint would cover the undefined function references.

@SchrodingersGat
Copy link
Member

We already do run eslint - https://github.com/inventree/InvenTree/blob/master/.eslintrc.yml - so we should look into why it did not catch this incorrect function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping items from sales order fails due to typo
4 participants