Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/settings bugs and added model SettingKeyType typing #4944

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

wolflu05
Copy link
Contributor

@wolflu05 wolflu05 commented Jun 1, 2023

This PR fixes various issues related to settings:

  • setting get cached even there are not saved yet (have no pk) which leads to trying to recreate them which fails
    This was pretty hard to find, I located that issue with git bisect using 61481b4 as bad commit, 0ffe786 as good commit and got 16ff193 as first bad commit.
  • add model key to SettingsKeyType (was actually the initiator of this PR)
  • plugin slugs that contain - can't use settings because the API re_path doesn't include - chars
  • related fields cannot be reseted, instead there is an js error thrown that data.value.toString() cannot be called on null
  • spelling mistakes discovered while debugging in the code (I have this extension installed to prevent them while I'm coding)

@wolflu05 wolflu05 self-assigned this Jun 1, 2023
@wolflu05 wolflu05 added the bug Identifies a bug which needs to be addressed label Jun 1, 2023
@wolflu05 wolflu05 modified the milestones: 0.11.3, 0.12.0 Jun 1, 2023
@wolflu05 wolflu05 mentioned this pull request Jun 1, 2023
@SchrodingersGat
Copy link
Member

@wolflu05 some subtle fixes here, looks good :)

@SchrodingersGat SchrodingersGat merged commit 4d9e920 into inventree:master Jun 1, 2023
13 checks passed
@wolflu05 wolflu05 deleted the fix/settings branch February 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants