Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common spelling mistakes #4956

Merged
merged 15 commits into from
Jun 3, 2023
Merged

Fix common spelling mistakes #4956

merged 15 commits into from
Jun 3, 2023

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Jun 2, 2023

We have a lot of spelling mistakes in the codebase, as recent PRs showed. This PR:

  • adds spell checking to the hook pipeline
  • fixes existing mistakes so we have a clean running CI

@matmair matmair added the CI CI / unit testing ecosystem label Jun 2, 2023
@matmair matmair self-assigned this Jun 2, 2023
@wolflu05
Copy link
Contributor

wolflu05 commented Jun 3, 2023

Nice addition, was already using a vscode extension, but doing this as part of linting is the better solution.

@SchrodingersGat
Copy link
Member

Wow quite a large number of errors 😕

@matmair matmair marked this pull request as ready for review June 3, 2023 10:54
SchrodingersGat
SchrodingersGat approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@SchrodingersGat SchrodingersGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some actual bugs in here which the spellcheck has fixed, too...

@SchrodingersGat SchrodingersGat merged commit 21ed4b2 into inventree:master Jun 3, 2023
13 checks passed
@SchrodingersGat
Copy link
Member

Thanks @matmair for looking into this :)

@matmair matmair deleted the check-spelling branch June 3, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingersGat SchrodingersGat SchrodingersGat approved these changes

Assignees

@matmair matmair

Labels
CI CI / unit testing ecosystem refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matmair @wolflu05 @SchrodingersGat