Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent div-by-zero error #4967

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Prevent div-by-zero error #4967

merged 1 commit into from
Jun 5, 2023

Conversation

SchrodingersGat
Copy link
Member

  • Div-by-zero could occur when calculating how many items can be built for a part
  • Might result if (somehow) the BomItem has a quantity of zero

@SchrodingersGat
Prevent div-by-zero error
d5276de 
- Div-by-zero could occur when calculating how many items can be built for a part
- Might result if (somehow) the BomItem has a quantity of zero
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action backport-to-0.11.x labels Jun 5, 2023
@SchrodingersGat SchrodingersGat added this to the 0.12.0 milestone Jun 5, 2023
@SchrodingersGat SchrodingersGat mentioned this pull request Jun 5, 2023
Merged
@SchrodingersGat SchrodingersGat merged commit d8965c6 into inventree:master Jun 5, 2023
15 checks passed
@SchrodingersGat SchrodingersGat deleted the div-by-zero branch June 5, 2023 03:40
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
@SchrodingersGat
Prevent div-by-zero error (#4967)
1b1880d 
- Div-by-zero could occur when calculating how many items can be built for a part
- Might result if (somehow) the BomItem has a quantity of zero

(cherry picked from commit d8965c6)
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

💚 All backports created successfully

Status Branch Result
✅ 0.11.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Jun 5, 2023
@github-actions @SchrodingersGat
Prevent div-by-zero error (#4967) (#4968)
1c4362c 
- Div-by-zero could occur when calculating how many items can be built for a part
- Might result if (somehow) the BomItem has a quantity of zero

(cherry picked from commit d8965c6)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SchrodingersGat