Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table custom buttons #5075

Merged
merged 21 commits into from
Jun 19, 2023

Conversation

SchrodingersGat
Copy link
Member

Refactor action buttons for tables.

  • Replaces server-side tempalted code with javascript
  • Consistent "look and feel"
  • Will better suit future UI refactor
  • Bug fixes

- Commonize code against tables
- Cleaner UI
- Better code
- Will make future react refactor easier
- Separate .js file for dynamically checking permissions
- Prevent some really strange API calls
- Now done dynamically
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface api Relates to the API refactor labels Jun 19, 2023
@SchrodingersGat SchrodingersGat added this to the 0.12.0 milestone Jun 19, 2023
@SchrodingersGat SchrodingersGat merged commit 4c9d4ad into inventree:master Jun 19, 2023
12 checks passed
@SchrodingersGat SchrodingersGat deleted the table-custom-buttons branch June 19, 2023 21:45
@matmair
Copy link
Contributor

matmair commented Jun 19, 2023

great refactor @SchrodingersGat !

@SchrodingersGat
Copy link
Member Author

Some seriously old code in there!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API bug Identifies a bug which needs to be addressed refactor user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants