-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table custom buttons #5075
Merged
SchrodingersGat
merged 21 commits into
inventree:master
from
SchrodingersGat:table-custom-buttons
Jun 19, 2023
Merged
Table custom buttons #5075
SchrodingersGat
merged 21 commits into
inventree:master
from
SchrodingersGat:table-custom-buttons
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commonize code against tables - Cleaner UI - Better code - Will make future react refactor easier
- Separate .js file for dynamically checking permissions
- Prevent some really strange API calls
- Now done dynamically
SchrodingersGat
added
bug
Identifies a bug which needs to be addressed
user interface
User interface
api
Relates to the API
refactor
labels
Jun 19, 2023
- no longer needed - Cleanup, yay!
- remove extra div elements
great refactor @SchrodingersGat ! |
Some seriously old code in there!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Relates to the API
bug
Identifies a bug which needs to be addressed
refactor
user interface
User interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor action buttons for tables.