Unit Test Improvements #5087
Merged
Unit Test Improvements #5087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Compare how long the unit tests take
- To get unit tests to run
- Remove coverage task - Add --coverage flag to test task
- Should cause migration unit tests to be run
- Should save some time
- Display time taken to load each plugin
matmair
approved these changes
Jun 22, 2023
|
@SchrodingersGat has slowtests a sizeable impact? |
- Might remove this entirely? - For now, bypass for unit testing
- Display time taken to load registry
- env var updates - change paths-filter output
- Actually need to set the output
|
@matmair in summary:
Overall this is a 50% reduction in unit testing time - further improvements can still be made but I suspect with diminishing returns. |
|
Looks great @SchrodingersGat ! Is there any inherent reason to spilt out the migration tests into a separate file? The job could also be run parallel as a separate job in the main qc.yaml IIRC. |
|
No inherent reason, I just thought it made sense to keep them distinct. The ci checks file is getting very difficult to understand |
|
Would you be open to merging the files? Having one QC file makes monitoring and automation easier downstream. |
|
I'm not opposed to it :) if you submit a PR I'll merge! |
matmair
added a commit
to matmair/InvenTree
that referenced
this pull request
Jun 25, 2023
Merged
SchrodingersGat
pushed a commit
that referenced
this pull request
Jun 25, 2023
* merge workflows from #5087 * syntax fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4821
Not running the migration tests shaves 10 minutes (25%) off the unit testing