Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli on 22.04 #5204

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Fix cli on 22.04 #5204

merged 2 commits into from
Jul 8, 2023

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Jul 8, 2023 •
edited

This PR fixes cli runs on ubuntu 22.04 and higher with packed installs.
Needs a release to be pushed to install base.

@matmair matmair self-assigned this Jul 8, 2023
@matmair matmair added bug Identifies a bug which needs to be addressed setup Relates to the InvenTree setup / installation process labels Jul 8, 2023
@matmair matmair added this to the 0.12.1 milestone Jul 8, 2023
@matmair matmair marked this pull request as ready for review July 8, 2023 22:07
@SchrodingersGat SchrodingersGat merged commit d4fad4f into inventree:master Jul 8, 2023
13 checks passed
@matmair matmair deleted the fix-cli-22.04 branch July 8, 2023 23:00
SchrodingersGat pushed a commit to SchrodingersGat/InvenTree that referenced this pull request Aug 3, 2023
@matmair @SchrodingersGat
fix cli on 22.04 (inventree#5204)
892814d 
(cherry picked from commit d4fad4f)
This was referenced Aug 3, 2023
Merged
Closed
SchrodingersGat added a commit that referenced this pull request Aug 3, 2023
@SchrodingersGat @matmair
fix cli on 22.04 (#5204) (#5395)
f526dcd 
* fix cli on 22.04 (#5204)

(cherry picked from commit d4fad4f)

* Update weasyprint docs link

* Another link fix

---------

Co-authored-by: Matthias Mair <code@mjmair.com>
@SchrodingersGat
Copy link
Member

@matmair I believe that this change may be why the inventree run cli command is not working - as per this discussion

If the installer is running on Ubuntu 20.04 (like my WSL setup) then the extra echo "" && at the start is seeming to cause the rest of the line not to be run. This is why @imager2019 is not getting any output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matmair matmair

Labels
bug Identifies a bug which needs to be addressed setup Relates to the InvenTree setup / installation process
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matmair @SchrodingersGat