Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: add missing reporting libs #5213

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

SchrodingersGat
Copy link
Member

Ref: #5007

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed docker Docker / docker-compose setup Relates to the InvenTree setup / installation process labels Jul 10, 2023
@SchrodingersGat SchrodingersGat added this to the 0.13.0 milestone Jul 10, 2023
@wolflu05
Copy link
Contributor

wolflu05 commented Jul 10, 2023

Was this intentional, or an oversight? We'll need to add these back in.

Missed the poppler-utils one, but the rest was intentional as they do not exist on alpine, see, hopefully it works even without them. Unfortunately, I already testet label generation and it worked.

But your changes do not work, I suggest adding only poppler-utils to this line

py3-pip py3-pillow py3-cffi py3-brotli pango \

@SchrodingersGat
Copy link
Member Author

But your changes do not work

Do not work how? The docker image builds OK for me?

@wolflu05
Copy link
Contributor

Do not work how? The docker image builds OK for me?

Yes, it's basically the same as without your changes. Look closely at the last line where you added the \ the fc-cache command just ignores the extra args you provided. You need to add them to a apk add command. I suggest adding it to L60, because there is the other report stuff.

@SchrodingersGat
Copy link
Member Author

Yes, it's basically the same as without your changes. Look closely at the last line where you added the \ the fc-cache command just ignores the extra args you provided. You need to add them to a apk add command. I suggest adding it to L60, because there is the other report stuff.

Ah, yes ok that is obvious now :)

@wolflu05
Copy link
Contributor

wolflu05 commented Jul 10, 2023

Keep an eye on the size, not sure if we really need the added packages, I looked at the official docs and that's why I didn't add them.

Image is now at 588MB on my machine.

@SchrodingersGat
Copy link
Member Author

Keep an eye on the size, not sure if we really need the added packages, I looked at the official docs and that's why I didn't add them.

Yep, looks like unit tests pass correctly without them, so have removed again :)

@SchrodingersGat SchrodingersGat merged commit 92b0a19 into inventree:master Jul 10, 2023
12 of 13 checks passed
@SchrodingersGat SchrodingersGat deleted the docker-image-fix branch July 10, 2023 11:12
@SchrodingersGat
Copy link
Member Author

@wolflu05 very nice work :) The size difference is impressive

Screenshot 2023-07-10 at 10 44 03 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed docker Docker / docker-compose setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants