Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors when printing reports #5360

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Handle errors when printing reports #5360

merged 1 commit into from
Jul 28, 2023

Conversation

SchrodingersGat
Copy link
Member

  • Re-throw as a ValidationError
  • Results in a 400 error, not a 500
  • Logs the error to the database

@SchrodingersGat
Handle errors when printing reports
52db067 
- Re-throw as a ValidationError
- Results in a 400 error, not a 500
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed api Relates to the API backport Apply this label to a PR to enable auto-backport action backport-to-0.12.x labels Jul 28, 2023
@SchrodingersGat SchrodingersGat added this to the 0.13.0 milestone Jul 28, 2023
@SchrodingersGat SchrodingersGat added the report Report generation label Jul 28, 2023
@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited

✅ Deploy Preview for inventree canceled.

Name Link
🔨 Latest commit 52db067
🔍 Latest deploy log https://app.netlify.com/sites/inventree/deploys/64c332c00d66790008e89df6

@SchrodingersGat SchrodingersGat merged commit 5f3d3b2 into inventree:master Jul 28, 2023
26 checks passed
@SchrodingersGat SchrodingersGat deleted the report-error-catch branch July 28, 2023 03:47
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
@github-actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.12.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Jul 28, 2023
@SchrodingersGat
Handle errors when printing reports (#5360)
c57f7cc 
- Re-throw as a ValidationError
- Results in a 400 error, not a 500

(cherry picked from commit 5f3d3b2)
SchrodingersGat added a commit that referenced this pull request Jul 28, 2023
@github-actions @SchrodingersGat
Handle errors when printing reports (#5360) (#5361)
946fe2d 
- Re-throw as a ValidationError
- Results in a 400 error, not a 500

(cherry picked from commit 5f3d3b2)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Relates to the API backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed report Report generation
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SchrodingersGat