Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUI: Scan Page #5500

Merged
merged 21 commits into from
Sep 15, 2023
Merged

PUI: Scan Page #5500

merged 21 commits into from
Sep 15, 2023

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Sep 3, 2023

This PR adds an experimental new page: the Scan Page.
grafik
This page allows users to scan multiple barcodes at once and execute actions against them. Scans are saved locally.

This is currently WIP as it depends on actions (for parts, stockitems, ...) to be implemented in PUI so they can be called from this page. Nevertheless I would be happy to get feedback.

@matmair matmair added enhancement This is an suggested enhancement or new feature barcode Barcode scanning and integration Platform UI Related to the React based User Interface labels Sep 3, 2023
@matmair matmair added this to the 0.13.0 milestone Sep 3, 2023
@matmair matmair self-assigned this Sep 3, 2023
@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for inventree ready!

Name Link
🔨 Latest commit ad4a782
🔍 Latest deploy log https://app.netlify.com/sites/inventree/deploys/65039bb282253c000771abfc
😎 Deploy Preview https://deploy-preview-5500--inventree.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 86
Best Practices: 100
SEO: 70
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair
Copy link
Contributor Author

matmair commented Sep 7, 2023

Updated screenshot
grafik

@matmair matmair marked this pull request as ready for review September 7, 2023 22:37
@matmair
Copy link
Contributor Author

matmair commented Sep 7, 2023

@inventree/triage this would be ready for a feedback round. You can reach the page by selecting "Scanning" in the navigation pane.
You either need to run on localhost or serve via https to test this as access to camera APIs is restricted.

I would be interested if:

  • the structure makes sense
  • scanning of barcodes works on your end
  • the texts make sense

and what actions should be exposed for the available barcodes (see screenshot above)

@SchrodingersGat
Copy link
Member

@matmair new screenshot looks amazing! I'll try to find some time to look at it this weekend :)

@SchrodingersGat
Copy link
Member

@matmair to clarify the intent here, this dedicated barcode page is intended to be separate from the "quick scan" barcode action?

Quick Scan Action

Scans a barcode, and if identified as an "inventree" barcode (e.g part / location / etc) it will navigate the UI to the relevant page. No other actions, just scan

New Barcode Screen

Dedicated for more complex barcode data entry. Scan multiple barcodes, and then perform specific actions with those barcodes:

  • check into location
  • receive against purchase order
  • assign to build order

@matmair
Copy link
Contributor Author

matmair commented Sep 14, 2023

@SchrodingersGat yes, you described it well.

@SchrodingersGat
Copy link
Member

I'm happy with the general idea, do you want to merge in now and update as we go?

@matmair
Copy link
Contributor Author

matmair commented Sep 15, 2023

Sounds good @SchrodingersGat

@SchrodingersGat SchrodingersGat merged commit ee64d12 into inventree:master Sep 15, 2023
20 checks passed
@matmair matmair deleted the pui-scan-page branch September 18, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barcode Barcode scanning and integration enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants