[0.12.x] Fix missing filters for get settings validator (#5480) #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix missing filters for get settings validator * merge default model instance filters and kwargs * Added tests for validators * Give it a try without the kwargs passed to clean in save function * Added string for identification for debug statement * Added more debug comments * Added more debug prints * Fix test debug * Modiefied workflow * trigger ci * Fix test and remove unused kwargs * Added debug prints * Only run one test in ci * Added more debug code * Remove all debug prints and reset workflow * Reset overlooked file (cherry picked from commit 9a6c2d2) # Conflicts: # InvenTree/plugin/samples/integration/test_sample.py
wolflu05
force-pushed
the
backport/0.12.x/pr-5480
branch
from
7041257
to
624ee8d
Compare
|
Don't wonder, I tried out this back port tool locally by adding a PAT because I thought it will be easier, but no, actually it was some kind of weird first. Not sure if it wouldn't be easier to do it with git directly if I need to manually do it again. |
|
Should work now, so it can be merged. I think the rest of the failures are not related to my changes, because they are also present in the previous runs on the 0.12.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto0.12.x:Questions ?
Please refer to the Backport tool documentation