Plugin loading fixes #5572
Merged
Plugin loading fixes #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URL patterns were causing custom app mixin plugins to fail reverse lookup in admin interface - Brought admin URLs up one level
SchrodingersGat
added
bug
✅ Deploy Preview for inventree canceled.
|
- As we have updated InvenTree.urls.py we need to adjust this logic too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5523
This patch fixes two bugs which seem specific to AppMixin plugins:
External Plugins Dir
Loading AppMixin plugins from external (custom) plugins dir did not work correctly - there was no mechanism available to add these plugins to
INSTALLED_APPS. Some extra path checks fix thisAdmin URLs
Admin integration breaks (as reported in #5523) due to changes in 3e37469
Bring the admin URLs up one level to fix this.