Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P UI] Router syntax switch #5575

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Sep 20, 2023

This PR suggests a change of the used react-router syntax to make it more concise and easier to read - especially for nested routes.

@matmair matmair added refactor Platform UI Related to the React based User Interface labels Sep 20, 2023
@matmair matmair added this to the 0.13.0 milestone Sep 20, 2023
@matmair matmair self-assigned this Sep 20, 2023
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for inventree ready!

Name Link
🔨 Latest commit 42a1852
🔍 Latest deploy log https://app.netlify.com/sites/inventree/deploys/650a783517db1800081c11fa
😎 Deploy Preview https://deploy-preview-5575--inventree.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 86
Best Practices: 100
SEO: 70
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat
Copy link
Member

Yeah, this is heaps better

@SchrodingersGat SchrodingersGat merged commit 6c5b9e0 into inventree:master Sep 20, 2023
21 checks passed
@matmair matmair deleted the router-swich branch September 20, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants