[P UI] Make base url configurable #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmair
added
enhancement
✅ Deploy Preview for inventree ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Does it also support Ports ("http://some-nas:1337")? Because 0.12.7 doesn't :/ |
|
Ports already work, our dev environments work that way. PRs are not the right place to report problems if you want help though. That would be either discussions or issues. |
|
Agreed. I'll collect information and report a bug. I just thought it's a full makeover so a bug would be obsolete. Thanks 🙏 |
|
Seems like a straightforward change, thanks @matmair |
|
@SchrodingersGat I am just splitting out all the side noice from #5559 so you can review that ;-) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the base URL (by default platform) configurable. This way the admin can select under which subpath P UI should be server (or if it should not use a subpath at all).