Feature/Tree picker #5595
Merged
Feature/Tree picker #5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wolflu05
added
user interface
matmair
approved these changes
Sep 23, 2023
|
You're right, missed that, added it now. |
|
@wolflu05 sorry for the delayed response on this one - it looks fantastic! No notes :) |
|
Thanks that you like this. To build this in PUI, I think it would be better to build the tree component first. From my research, we could use this library which is unsing virtualization what drastically improves performance on large data sets. They show an example with 1848897 nodes and the performance is awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bothered me since a long time. It is very hard if one has locations with the same repeating name to search for them by a tree path. To improve the experience I added a tree picker to the forms which shows the tree in a new modal to select the correct path. Additionally, this improves the backdrop for secondary, ... modals, so that only the top modal is infront of the backdrop.
inventree-tree-picker.mp4
This could have some performance issues like the top navigation has them too, but this is related to the jQuery tree view library. I hope we can implement something like this in PUI sometime too. But for now this PR is ready to review.