-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ignore parts without stock in stocktake #5627
Conversation
✅ Deploy Preview for inventree canceled.
|
I guess the CI fails for other reasons then my changes, right? |
@lippoliv can you please merge in the changes from latest master so we can get this one merged? |
@SchrodingersGat done |
Looks like some of the unit tests will have to be adjusted too :) |
@lippoliv what exactly are you running to get that error message? You should be able to (from the command line in devcontainer) run something like:
|
I set up VS Code as described in devcontainers. Then I told it what python testing we use. I end up in the screenshot I showed before. In
Is that a bug? However I adapted your command line (thanks for the help) and ended up with |
LGTM, thanks for the contribution @lippoliv |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
- Backport of inventree#5627
- Backport of #5627 Co-authored-by: Oliver Lippert <oliver@allesit.de>
Fixes #5621
Currently in
Stocktake
(no matter if it's the export or update parts) we ignorePart
s with 0 stock. This PR fixes that.Backport
I would love to see this being backported to 0.12.x, but it will not work automatically I guess. It's simliar lines, but in another file (https://github.com/inventree/InvenTree/blob/0.12.x/InvenTree/part/tasks.py#L317-L319).