[React] Part parameters table #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters-table # Conflicts: # src/frontend/src/components/nav/PanelGroup.tsx
- Still requires more attention
- Need to rebuild columns when part id changes
- useLocalStorage - Change got clobbered in recent merge conflict
- Can be improved later
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wolflu05
reviewed
Oct 16, 2023
| import { t } from '@lingui/macro'; | ||
| import { Badge } from '@mantine/core'; | ||
|
|
||
| export function YesNoButton(value: any) { |
There was a problem hiding this comment.
I think you forgot the destructuring.
Suggested change
| export function YesNoButton(value: any) { | |
| export function YesNoButton({ value: any }) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PartParameterTable to the new interface.
Also implements a bunch of other new features and fixes required to get this all working.