Remove stockitemmanager #5727
Merged
Remove stockitemmanager #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
- Not used anywhere - Reference: inventree#5586
SchrodingersGat
force-pushed
the
remote-stockitemmanager
branch
from
3857575
to
0967014
Compare
|
Sean like this could Safe some queries. Any idea why this stopped being used? |
|
Some simple testing indicates that it is actually more expensive to use this manager everywhere - I guess we have spent enough time optimizing each individual API endpoint / query that this "big hammer" approach is not helpful |
|
Intestine inside; might be something to watch out for in sentry data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove class which is not used anywhere