Part responsible owner #5774
Merged
Part responsible owner #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SchrodingersGat
commented
Oct 23, 2023
SchrodingersGat
commented
- Replaces Part responsible #5060
- Fixes Part responsible is limited to a User, groups not allowed #5059
- Will replace "responsible" field
- Adds 'responsible_owner' value for parts which have 'responsible' set - Selects correct content type - Performs reverse migratoin
- Point to the new field - Rename to preserve compatibility - OPTIONS metadata will take care of the rest
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
matmair
approved these changes
Oct 23, 2023
InvenTree/part/serializers.py
Outdated
Comment on lines
699
to
703
| responsible = serializers.PrimaryKeyRelatedField( | ||
| queryset=users.models.Owner.objects.all(), | ||
| source='responsible_owner', | ||
| ) | ||
|
|
There was a problem hiding this comment.
Comment: This should lead to a bumb of the API version, right?
|
@miggland FYI this is how complex migrations should be handled. In separate sequential migrations:
Data and schema migrations should not be performed in the same step. And it should be written in such a way that it is reversible if required :) |
|
Looks nice, thanks for fixing this. 👍 |
|
No worries, it is a pretty tricky thing to get right! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.