Recursive delete fix fix #5819
Merged
Recursive delete fix fix #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SchrodingersGat
added
bug
- Ensure that the "parent" field is set to None before delete - This means that we do not violate any ForeignKey constraints due to undefined order of operations
wolflu05
reviewed
Oct 31, 2023
| @@ -274,7 +274,6 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
|
|
|||
| needs: [ 'pep_style', 'pre-commit' ] | |||
| if: github.event_name == 'push' | |||
There was a problem hiding this comment.
@SchrodingersGat I guess you don't wanted to remove that for merge?
There was a problem hiding this comment.
The various backend tests don't take that long any more, I think it is worth checking that the supported databases are tested on PR as well as push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix bug introduced in recent PR which only seems to be an issue for mysql backend.
Ref: #5806