Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Small nav additions #5855

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Nov 3, 2023

This PR:

  • Adds more nav items (everything that is in the header)
  • changes the action on the InvenTree logo to open nav instead of going home

@matmair matmair added the Platform UI Related to the React based User Interface label Nov 3, 2023
@matmair matmair added this to the 0.13.0 milestone Nov 3, 2023
@matmair matmair self-assigned this Nov 3, 2023
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 2e17c33
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/654579d208fec40007e59453
😎 Deploy Preview https://deploy-preview-5855--inventree-web-pui-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat
Copy link
Member

Nice addition :) Can I request some small aesthetic tweaks:

  • Make the elements larger, with more padding. they are hard to click!
  • Add an icon to each one, similar to what we have on the nav bar in CUI

@matmair
Copy link
Contributor Author

matmair commented Nov 4, 2023

I can add the padding but I do not really see the point with icons, we do not have them in the header nav either

@SchrodingersGat
Copy link
Member

@matmair happy to merge in now, can continue to tweak as we go :)

@SchrodingersGat SchrodingersGat merged commit 2559814 into inventree:master Nov 6, 2023
24 checks passed
@matmair matmair deleted the pui-nav-adds branch November 7, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants