Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Order tables #5860

Merged
merged 18 commits into from
Nov 5, 2023

Conversation

SchrodingersGat
Copy link
Member

Improvements to the order tables, including some API changes to annotate more useful information

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 37ee69f
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6546c3413ba447000842c18e
😎 Deploy Preview https://deploy-preview-5860--inventree-web-pui-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat added order Related to purchase orders / sales orders user interface User interface api Relates to the API Platform UI Related to the React based User Interface labels Nov 4, 2023
Copy link
Contributor

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;
would it maybe make sense to add optional attributes to column definitions to define common formaters like project code, data, money, user, owner?

@SchrodingersGat
Copy link
Member Author

lgtm; would it maybe make sense to add optional attributes to column definitions to define common formaters like project code, data, money, user, owner?

I was just wondering that, there is certainly a lot of repetition.

@matmair
Copy link
Contributor

matmair commented Nov 4, 2023

lgtm; would it maybe make sense to add optional attributes to column definitions to define common formaters like project code, data, money, user, owner?

I was just wondering that, there is certainly a lot of repetition.

Should I create a follow-up PR to this and #5771 to make that happen?

@SchrodingersGat
Copy link
Member Author

Should I create a follow-up PR to this and #5771 to make that happen?

Adding it in here :)

Copy link
Contributor

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchrodingersGat SchrodingersGat merged commit dbf1baf into inventree:master Nov 5, 2023
24 checks passed
@SchrodingersGat SchrodingersGat deleted the sales-order-table branch November 5, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API order Related to purchase orders / sales orders Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants