-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React] Order tables #5860
[React] Order tables #5860
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Annotate 'completed_lines' to each order type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm;
would it maybe make sense to add optional attributes to column definitions to define common formaters like project code, data, money, user, owner?
I was just wondering that, there is certainly a lot of repetition. |
Should I create a follow-up PR to this and #5771 to make that happen? |
Adding it in here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improvements to the order tables, including some API changes to annotate more useful information