Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker CI Updates #5909

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Docker CI Updates #5909

merged 11 commits into from
Nov 21, 2023

Conversation

SchrodingersGat
Copy link
Member

  • Also, build docker image on PR if any docker-related files have changed

Ref: #5889

@SchrodingersGat
Update docker image - base python version
d179c47 
- Also, build docker image on PR if any docker-related files have changed
@SchrodingersGat SchrodingersGat added CI CI / unit testing ecosystem dependency Relates to a project dependency docker Docker / docker-compose labels Nov 13, 2023
@SchrodingersGat SchrodingersGat added this to the 0.13.0 milestone Nov 13, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 14f6b75
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/655ca994a8f4a30008b96a83

@SchrodingersGat
Copy link
Member Author

@matmair I got the docker image to at least build, by updating the base package requirements for the image itself. But now the unit tests are failing. Do you have any issues with plugin installation, running 3.11?

@matmair matmair mentioned this pull request Nov 13, 2023
Merged
@matmair
Copy link
Contributor

matmair commented Nov 13, 2023

@SchrodingersGat I use wheels for my installs and had no problems, I will look into this one (which we build).

@matmair
Copy link
Contributor

matmair commented Nov 19, 2023

This is an interesting problem, I still ger an error with an updated minimum every 5-10 times. Will need to investigate - maybe we push this to 0.14.0?

@SchrodingersGat SchrodingersGat changed the title Update docker image - base python version Docker CI Updates Nov 21, 2023
@SchrodingersGat
Copy link
Member Author

@matmair yes let's push the update - however I'll revert the python version and merge this in. The CI workflow updates are useful by themselves

@SchrodingersGat SchrodingersGat merged commit 15b2437 into inventree:master Nov 21, 2023
26 checks passed
@SchrodingersGat SchrodingersGat deleted the docker-ci-fix branch November 21, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair Awaiting requested review from matmair

Assignees
No one assigned
Labels
CI CI / unit testing ecosystem dependency Relates to a project dependency docker Docker / docker-compose
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SchrodingersGat @matmair