Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added order cancel notifications #5912

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Nov 13, 2023

This PR adds notifications when an order is canceld (additonally to the event already present).

commit 5e8ea09
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 09:22:38 2023 +0200

    Update ui_plattform.spec.ts

commit 49da331
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 07:56:25 2023 +0200

    more logging

commit 5337be4
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 07:56:11 2023 +0200

    added filter method for undefined settings that overwrite defaults

commit 5df8a0b
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 03:05:06 2023 +0200

    you do not need to string a string

commit 0650d3b
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 03:04:34 2023 +0200

    fix things that were borken for no good reason

commit a40dbfd
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 02:39:34 2023 +0200

    reduce unneeded blocking timeouts

commit bf9046a
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 02:34:10 2023 +0200

    catch server fetching errors

commit aa01e67
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 02:33:29 2023 +0200

    move init as things are now plugged together different

commit 290c33b
Author: Matthias Mair <code@mjmair.com>
Date:   Tue Oct 24 01:49:32 2023 +0200

    do not log a failed automatic login try - why would you?
@matmair matmair added enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders labels Nov 13, 2023
@matmair matmair added this to the 0.13.0 milestone Nov 13, 2023
@matmair matmair self-assigned this Nov 13, 2023
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 57f4015
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6553ef7426ef5a00081a2606

@matmair matmair marked this pull request as ready for review November 13, 2023 21:51
@matmair matmair changed the title Added order notifications Added order cancel notifications Nov 13, 2023
@SchrodingersGat
Copy link
Member

@matmair nice addition. Can you please extend this to build orders too?

@matmair
Copy link
Contributor Author

matmair commented Nov 14, 2023

I added it but IMO Orders and Builds should be handled seperate from each other, they are pretty different. Sales, Purchase and Return Orders could probably be substantailly reduced with some more generalisation.

@SchrodingersGat
Copy link
Member

@matmair nice work, thanks :)

@SchrodingersGat SchrodingersGat merged commit 5be6bc8 into inventree:master Nov 14, 2023
23 checks passed
@matmair matmair deleted the order-notifications branch November 14, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants