Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring supplier barcode support #5922

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Refactoring supplier barcode support #5922

merged 5 commits into from
Nov 15, 2023

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Nov 15, 2023 •
edited

  • Add a set of standard field name strings
  • Map from custom fields to standard fields
  • Helper functions for returning common field data
  • Updated unit tests

TODO

  • Get unit tests to pass still
  • Add unit tests for more barcodes (especially 30P variant of Digikey Barcode)
  • Remove debug print statements

@SchrodingersGat
Refactoring supplier barcode support
5ae83b0 
- Add a set of standard field name strings
- Map from custom fields to standard fields
- Helper functions for returning common field data
- Updated unit tests
@SchrodingersGat SchrodingersGat added barcode Barcode scanning and integration plugin Plugin ecosystem labels Nov 15, 2023
@SchrodingersGat SchrodingersGat added this to the 0.13.0 milestone Nov 15, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 704c2d2
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6554b68b03f9ca00088260fc
😎 Deploy Preview https://deploy-preview-5922--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

matmair
matmair reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchrodingersGat SchrodingersGat merged commit df0da18 into inventree:master Nov 15, 2023
24 checks passed
@SchrodingersGat SchrodingersGat deleted the supplier-barcode-improvements branch November 15, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair matmair left review comments

Assignees
No one assigned
Labels
barcode Barcode scanning and integration plugin Plugin ecosystem
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SchrodingersGat @matmair