Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle full name display of users #5927

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

LavissaWoW
Copy link
Contributor

Would've closed #5222 if it was still open

* InvenTree Setting added to allow for admins to choose full names
  over usernames for display in the web GUI
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 1939ca7
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65556e370acf120008a2806c

@SchrodingersGat SchrodingersGat added this to the 0.13.0 milestone Nov 16, 2023
@SchrodingersGat
Copy link
Member

@LavissaWoW thanks, looks good to me :)

@SchrodingersGat SchrodingersGat merged commit e2b29cb into inventree:master Nov 16, 2023
24 checks passed
@wolflu05
Copy link
Contributor

Wouldn't it make sense to also add this new setting to PUI so that they don't get out of sync?

@SchrodingersGat
Copy link
Member

@wolflu05 yep, that's a good point. @LavissaWoW would you be able to implement a similar change into the new react frontend?

@matmair
Copy link
Contributor

matmair commented Nov 19, 2023

In this case, adding the key of the setting somewhere here should be enough BTW

'INVENTREE_BASE_URL',
'INVENTREE_COMPANY_NAME',
'INVENTREE_INSTANCE',
'INVENTREE_INSTANCE_TITLE',
'INVENTREE_RESTRICT_ABOUT',
'INVENTREE_UPDATE_CHECK_INTERVAL',
'INVENTREE_DOWNLOAD_FROM_URL',
'INVENTREE_DOWNLOAD_IMAGE_MAX_SIZE',
'INVENTREE_DOWNLOAD_FROM_URL_USER_AGENT',
'INVENTREE_REQUIRE_CONFIRM',
'INVENTREE_TREE_DEPTH',
'INVENTREE_BACKUP_ENABLE',
'INVENTREE_BACKUP_DAYS',
'INVENTREE_DELETE_TASKS_DAYS',
'INVENTREE_DELETE_ERRORS_DAYS',
'INVENTREE_DELETE_NOTIFICATIONS_DAYS'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Owner: Show User's full name instead of username
4 participants