-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI/Feature] Integrate Part "Default Location" into UX #5972
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
@SchrodingersGat @matmair @wolflu05 To do all the work I'm planning here, I'll have to add some elements to Stock Items, Part Categories, and additionally Purchase Orders. I don't want to overlap work others are doing :) |
@LavissaWoW I do not have any active progress on any of the items you list. We have not implemented any "detail" pages yet - I would be keen to see if we can develop a standard component or set of components for rendering a "detail" view - primarily for UI consistency. If you want to tackle a detail page in the new UI that's great 👍 |
This PR seems stale. Please react to show this is still important. |
@LavissaWoW not stale, right? |
Not stale indeed. Need to sort out priorities here though. I got some backend shenanigans planned, and several frontend changes. |
@SchrodingersGat I'm inclined to ignore CUI with this. |
@wolflu05 @SchrodingersGat The use for this is forms where we pass arrays of objects ot the API. For this PR, I'll use it for Stock operations. |
Nice idea to implement this as a field type. After reading array field, I first was thinking something different, but after reading the implementation the name |
@LavissaWoW the table form UI looks really good :) |
I should probably handle the category defaults for CUI too. Feel free to review, though. I'll add one last commit asap |
@SchrodingersGat All good, this is ready now |
@LavissaWoW this is great, such a lot of work here :) Review below, there's a few points and suggestions but nothing major! Stock Table ActionsWhen no items are selected, either: a) Disable the "actions" column, or Otherwise, you get this "no entries available" message In fact, this goes for other table forms too. If there are no available lines when opening the form, we need a "default selection" here. Receive Line ItemsReally good! Perhaps the modal should be wider by default? Receive Line Items - Default LocationLooks like the "default location" does not propagate here? This part does have a "default location" set: Although it should also work if there is a "default category location" Category Detail PageShould display the "default location" for the category (or upstream parent category as required). Currently not displayed: |
@SchrodingersGat Aside from the propagating default to PO line, and the category detail panel, (I'll fix those) I looked at most of this myself. The APIForm modals have a default width defined deeply nested within the framework we've created to display them. I wanted the PO Receive to be wider, and the lack of width is why I hid the Table actions I concluded it's not possible to get all records from a given table as things are now. |
This is probably the best approach for now, until (if) we can work out a different approach. At least visually the user should be aware that they have no records selected and thus cannot perform actions |
@SchrodingersGat I was initially struggling to reproduce the PO line location, but it turns out I made a couple of mistakes, and it was even more broken than you experienced. The PO lines have a
My logic was off in my assumptions here, and I found myself with test data where previously received stock had been placed at the default location. So some of my logic indicated default, while it was actually previously received that triggered it. Additionally, the queryset annotation I added to StockItem ofc. didn't magically carry over to POLineItems, so Fix incoming shortly |
@LavissaWoW I realize that part of the issue was that I was viewing the netlify preview - which talks to the demo server, which in turn does not have the latest API. So, this will explain the discrepencies. |
@LavissaWoW thanks again for the great work here! |
commit 06c7ebf Author: Oliver <oliver.henry.walters@gmail.com> Date: Sat Mar 16 09:11:57 2024 +1100 Update docker_install.md (inventree#6723) * Update docker_install.md Add note about external access * Update docker_install.md commit a00d5ab Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 17:53:58 2024 +1100 Disable BOM requirement (inventree#6719) * Add new setting STOCK_ENFORCE_BOM_INSTALLATION - Defaults to True (legacy) * Add logic to bypass BOM check * Update CUI to reflect new logic * Render InstalledItemsTable in PUI commit 160d014 Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 17:12:53 2024 +1100 [PUI] Details Pages (inventree#6718) * Add "details" view to SupplierPart page * Fix PartActions * Add placeholder for actions * Add "title" option to DetailsTable * Add edit form to supplier part page * Fix link to manufacturer part * Add "details" view to ManufacturerPartDetail page * Add edit for ManufacturerPart * Create new manufacturer part from company table * Tweak ActionIcon commit 57a1a81 Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 12:24:17 2024 +1100 Reporting: Build line label fix (inventree#6717) * Fix "BuildLine" label in PUI - Point to "buildline" not "build" * Prevent escape closing template ediror * Update report docs * Fix for format_number - Prevent number from being represented as scientific notation commit 0196dd2 Author: Lavissa <lavissawow@gmail.com> Date: Fri Mar 15 02:06:18 2024 +0100 [PUI/Feature] Integrate Part "Default Location" into UX (inventree#5972) * Add default parts to location page * Fix name strings * Add Stock Transfer modal * Add ApiForm Table field * temp * Add stock transfer form to part, stock item and location * All stock operations for Item, Part, and Location added (except order new) * Add default_location category traversal, and initial PO Line Item Receive form * . * Remove debug values * Added PO line receive form * Add functionality to PO receive extra fields * . * Forgot to bump API version * Add Category Default to details panel * Fix stockItem query count * Fix reviewed issues * . * . * . * Prevent root category from checking parent for default location commit 6abd33f Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 00:24:48 2024 +1100 Report enhancements (inventree#6714) * Add "enabled" filter to template table * Cleanup * API endpoints - Add API endpoints for report snippet - List endpoint - Details endpoint * Update serializers - Add asset serializer - Update * Check for duplicate asset files - Prevent upload of duplicate asset files - Allow re-upload for same PK * Duplicate checks for ReportSnippet * Bump API version commit cbd94fc Author: Oliver <oliver.henry.walters@gmail.com> Date: Thu Mar 14 23:06:11 2024 +1100 Fix for caddyfile (inventree#6712) - Add "authorization" to Access-Control-Allow-Headers - CORS requests actually *work* now commit ec5ff64 Author: Lukas <76838159+wolflu05@users.noreply.github.com> Date: Thu Mar 14 13:03:30 2024 +0100 handle report previewing errors (inventree#6709) commit 267ff67 Author: Oliver <oliver.henry.walters@gmail.com> Date: Thu Mar 14 15:11:27 2024 +1100 [PUI] Updates (inventree#6707) * Add button to edit part category * Fix useMemo() * Edit stock location commit 610ea7b Author: Oliver <oliver.henry.walters@gmail.com> Date: Thu Mar 14 12:09:14 2024 +1100 Report: Add date rendering (inventree#6706) * Validate timezone in settings.py * Add helper functions for timezone information - Extract server timezone - Convert provided time to specified timezone * Add more unit tests * Remove debug print * Test fix * Add report helper tags - format_date - format_datetime - Update report templates - Unit tests * Add setting to control report errors - Only log errors to DB if setting is enabled * Update example report * Fixes for to_local_time * Update type hinting * Fix unit test typo commit 7de8738 Author: Oliver <oliver.henry.walters@gmail.com> Date: Wed Mar 13 21:37:56 2024 +1100 Update .env (inventree#6700) Fix comment - no need to change Caddyfile in most cases commit 2fef348 Author: Oliver <oliver.henry.walters@gmail.com> Date: Wed Mar 13 20:37:05 2024 +1100 Unit tests for HOST settings (inventree#6698) - CORS - ALLOWED_HOSTS
* Quick attempt at fixed form footer * slightly improve on lower res devices * Squashed commit of the following: commit 06c7ebf Author: Oliver <oliver.henry.walters@gmail.com> Date: Sat Mar 16 09:11:57 2024 +1100 Update docker_install.md (#6723) * Update docker_install.md Add note about external access * Update docker_install.md commit a00d5ab Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 17:53:58 2024 +1100 Disable BOM requirement (#6719) * Add new setting STOCK_ENFORCE_BOM_INSTALLATION - Defaults to True (legacy) * Add logic to bypass BOM check * Update CUI to reflect new logic * Render InstalledItemsTable in PUI commit 160d014 Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 17:12:53 2024 +1100 [PUI] Details Pages (#6718) * Add "details" view to SupplierPart page * Fix PartActions * Add placeholder for actions * Add "title" option to DetailsTable * Add edit form to supplier part page * Fix link to manufacturer part * Add "details" view to ManufacturerPartDetail page * Add edit for ManufacturerPart * Create new manufacturer part from company table * Tweak ActionIcon commit 57a1a81 Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 12:24:17 2024 +1100 Reporting: Build line label fix (#6717) * Fix "BuildLine" label in PUI - Point to "buildline" not "build" * Prevent escape closing template ediror * Update report docs * Fix for format_number - Prevent number from being represented as scientific notation commit 0196dd2 Author: Lavissa <lavissawow@gmail.com> Date: Fri Mar 15 02:06:18 2024 +0100 [PUI/Feature] Integrate Part "Default Location" into UX (#5972) * Add default parts to location page * Fix name strings * Add Stock Transfer modal * Add ApiForm Table field * temp * Add stock transfer form to part, stock item and location * All stock operations for Item, Part, and Location added (except order new) * Add default_location category traversal, and initial PO Line Item Receive form * . * Remove debug values * Added PO line receive form * Add functionality to PO receive extra fields * . * Forgot to bump API version * Add Category Default to details panel * Fix stockItem query count * Fix reviewed issues * . * . * . * Prevent root category from checking parent for default location commit 6abd33f Author: Oliver <oliver.henry.walters@gmail.com> Date: Fri Mar 15 00:24:48 2024 +1100 Report enhancements (#6714) * Add "enabled" filter to template table * Cleanup * API endpoints - Add API endpoints for report snippet - List endpoint - Details endpoint * Update serializers - Add asset serializer - Update * Check for duplicate asset files - Prevent upload of duplicate asset files - Allow re-upload for same PK * Duplicate checks for ReportSnippet * Bump API version commit cbd94fc Author: Oliver <oliver.henry.walters@gmail.com> Date: Thu Mar 14 23:06:11 2024 +1100 Fix for caddyfile (#6712) - Add "authorization" to Access-Control-Allow-Headers - CORS requests actually *work* now commit ec5ff64 Author: Lukas <76838159+wolflu05@users.noreply.github.com> Date: Thu Mar 14 13:03:30 2024 +0100 handle report previewing errors (#6709) commit 267ff67 Author: Oliver <oliver.henry.walters@gmail.com> Date: Thu Mar 14 15:11:27 2024 +1100 [PUI] Updates (#6707) * Add button to edit part category * Fix useMemo() * Edit stock location commit 610ea7b Author: Oliver <oliver.henry.walters@gmail.com> Date: Thu Mar 14 12:09:14 2024 +1100 Report: Add date rendering (#6706) * Validate timezone in settings.py * Add helper functions for timezone information - Extract server timezone - Convert provided time to specified timezone * Add more unit tests * Remove debug print * Test fix * Add report helper tags - format_date - format_datetime - Update report templates - Unit tests * Add setting to control report errors - Only log errors to DB if setting is enabled * Update example report * Fixes for to_local_time * Update type hinting * Fix unit test typo commit 7de8738 Author: Oliver <oliver.henry.walters@gmail.com> Date: Wed Mar 13 21:37:56 2024 +1100 Update .env (#6700) Fix comment - no need to change Caddyfile in most cases commit 2fef348 Author: Oliver <oliver.henry.walters@gmail.com> Date: Wed Mar 13 20:37:05 2024 +1100 Unit tests for HOST settings (#6698) - CORS - ALLOWED_HOSTS * Make ApiForms shrinkable, spoiler long group list * Improve API Form Scroll Behavior * Fix incorrect modal component * Force load all modal fields to trigger loading animation * Show loading overlay while fetching fields
Closes #5928
Closes #5938