[PUI] Move UI rendering out of App.tsx #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes bundles that just use API components (eg. to render out PUI settings controls for inclusion CUI) much easier
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
This reverts commit 712f27b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes keeping bundles that just use API components (eg. to render out PUI settings controls for inclusion CUI) smaller much easier as the exporter
apiis used nearly everywhere.Before the individual views were not lazy loaded in the main context of the
Appfile so that was no issue. A bug fix in the last bit changed that so now bundles that only use 1-2 components still get the views bundled up so artifacts are larger than need be.