New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix supplier barcode order numbers #6158
Fix supplier barcode order numbers #6158
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
(I'll add some test cases later to confirm this keeps working in later versions.) |
@30350n can you please provide some more specific information about how the current implementation is "broken"? |
Sure!
|
Actuall the implementation I came up is kind of convoluted I guess, I'll try to refactor it a bit. |
Not sure if this makes it better 😅 |
@30350n if you have the data on hand to test that this works, I'm satisfied with that. please keep an eye on whether this continues to work |
Thanks, will definitely do! I actually also wanted to confirm everythings actually working correctly with some tests but didn't find time to implement them yet. I'll try to get that down the coming days and create another PR 👍 (I did quickly test this on my production server though and it did the trick.) |
* Add tme barcode CPO field * Fix LCSC order number field * Fix mouser order number field * Fix get_purchase_orders logic * Refine get_purchase_orders logic * Slightly refactor get_purchase_orders logic
Seems like the logic for retrieving a purchase order from an order number from a supplier barcode got broken when refactoring. This fixes the logic and also some supplier specific details.