Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #6167

Merged
merged 24 commits into from Jan 10, 2024
Merged

CI updates #6167

merged 24 commits into from Jan 10, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Jan 7, 2024

This targets to make the CI faster and simpler:

  • replaced flake8 with ruff (mostly for speed improvements but also autoformatting)
  • moves djlint config to pyproject
  • moves isort config to pyproject
  • removes flake8 from CI and requirements (not necesarry anymore due to ruff)

mostly for speed improvements
Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 91a3f2c
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/659e846bba63eb0008564a95

@matmair matmair marked this pull request as ready for review January 7, 2024 19:54
@matmair matmair mentioned this pull request Jan 7, 2024
@SchrodingersGat
Copy link
Member

@matmair LGTM - any idea why the Style [Python] CI check is not completing?

@matmair
Copy link
Member Author

matmair commented Jan 10, 2024

@SchrodingersGat that step was a duplicate and is being removed with this PR so it is not runinnig -> thus not passing

@matmair
Copy link
Member Author

matmair commented Jan 10, 2024

You would need to adapt the protection rules and remove that one (or replace it with the pre-commit step) - I do not have access to those settings on this repo

@SchrodingersGat
Copy link
Member

Ok, fair enough. If you can fix the conflicting files I'm happy to merge

@matmair
Copy link
Member Author

matmair commented Jan 10, 2024

@SchrodingersGat done

@matmair matmair added enhancement This is an suggested enhancement or new feature CI CI / unit testing ecosystem labels Jan 10, 2024
@matmair matmair added this to the 0.14.0 milestone Jan 10, 2024
@matmair matmair self-assigned this Jan 10, 2024
@SchrodingersGat
Copy link
Member

Nice, thanks @matmair

@SchrodingersGat SchrodingersGat merged commit e1b670b into inventree:master Jan 10, 2024
41 checks passed
@SchrodingersGat SchrodingersGat deleted the ci-updates branch January 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants