Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow orders' creation date edit via API #6178

Conversation

martonmiklos
Copy link
Contributor

Fixes #6159

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit ec07ad8
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65bd636e6cb81c0008cb498b

@martonmiklos martonmiklos force-pushed the allow_order_creation_date_edit_via_api branch from 1bfcbb0 to 5f15688 Compare January 9, 2024 19:20
@martonmiklos martonmiklos marked this pull request as draft January 9, 2024 19:33
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders api Relates to the API labels Jan 10, 2024
@SchrodingersGat SchrodingersGat added this to the 0.14.0 milestone Jan 10, 2024
@SchrodingersGat
Copy link
Member

Thanks for tackling this one @martonmiklos :)

@martonmiklos
Copy link
Contributor Author

Thanks for tackling this one @martonmiklos :)

Yeah, I pulled back from review because the API integration test fails and I need to sort it out.

@matmair
Copy link
Member

matmair commented Feb 1, 2024

@martonmiklos could you merge in master and check if it works now? Would love to assist in debugging this if the error persists

@martonmiklos martonmiklos force-pushed the allow_order_creation_date_edit_via_api branch from 5f15688 to c80236b Compare February 2, 2024 18:09
@martonmiklos
Copy link
Contributor Author

@martonmiklos could you merge in master and check if it works now? Would love to assist in debugging this if the error persists

Done, let's see how the CI will progress this time.

@matmair
Copy link
Member

matmair commented Feb 3, 2024

From my POV this is ready for a review, If you agree please mark it as ready @martonmiklos

@martonmiklos martonmiklos marked this pull request as ready for review February 3, 2024 18:36
@martonmiklos
Copy link
Contributor Author

From my POV this is ready for a review, If you agree please mark it as ready @martonmiklos

Yes, I have no idea why the CI failed with timeout on DeepSource.
It was a lesson learned for me about the behavior of the serializers :)

@matmair
Copy link
Member

matmair commented Feb 3, 2024

Deepsource is mainly code quality/security stuff and can be ignored if the rest of the CI passes. It seems like there is some kind of issue on their server end.

@matmair
Copy link
Member

matmair commented Feb 3, 2024

@SchrodingersGat this is ready for review and merge; no idea why deepsource is timing out but this should not be blocking IMO.

@SchrodingersGat
Copy link
Member

@martonmiklos thanks for the contribution :)

@SchrodingersGat SchrodingersGat merged commit 74d0eb7 into inventree:master Feb 4, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Importing Data with Creation Dates
3 participants