Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Site ID Fixes #6390

Merged
merged 12 commits into from Feb 3, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Feb 2, 2024

This PR is a work in process to fix / simplify the site URL / multi-site support for InvenTree.

This fixes a few bugs and addresses some shortcomings of how the "site_url" parameter is configured.

Additionally, multi-site support is now disabled by default (a "breaking" change but most users would not use this feature at all). Disabling multi-site support makes a lot of things much simpler...

TODO

  • Add documentation around enabling multi-site support
  • Update SSO documentation (much simpler with multi-site support disabled)

References

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature breaking Indicates a major update or change which breaks compatibility labels Feb 2, 2024
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 23876ef
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65be23e15838ab0008d9d082

@SchrodingersGat SchrodingersGat added this to the 0.14.0 milestone Feb 2, 2024
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed setup Relates to the InvenTree setup / installation process labels Feb 2, 2024
@matmair
Copy link
Member

matmair commented Feb 2, 2024

@SchrodingersGat great improvement. Do you think adding site control to the admin view might be in-scope for this?

@SchrodingersGat
Copy link
Member Author

Do you think adding site control to the admin view might be in-scope for this?

Do you mean the PUI admin view? Site control is already available in the Django Admin view

@matmair
Copy link
Member

matmair commented Feb 2, 2024

@SchrodingersGat yes, sorry that was not phrased optimal

@SchrodingersGat
Copy link
Member Author

I do not see the value here - it would be a very small user set (if any) who are using multi-site support. There is still always the Django Admin site available if absolutely required to setup?

@matmair
Copy link
Member

matmair commented Feb 2, 2024

I think you are right, we can add it later

@SchrodingersGat SchrodingersGat merged commit 5bc0029 into inventree:master Feb 3, 2024
24 checks passed
@SchrodingersGat SchrodingersGat deleted the site-id-fix branch February 3, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a major update or change which breaks compatibility bug Identifies a bug which needs to be addressed enhancement This is an suggested enhancement or new feature setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email confirmation key missing domain
2 participants