Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Test result table #6430

Merged
merged 71 commits into from Feb 18, 2024
Merged

[WIP] Test result table #6430

merged 71 commits into from Feb 18, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Feb 6, 2024 •
edited

Porting the stock item test result table over to the new react interface.

TODO

  • Unit test for data migrations
  • Unit test for new API features
  • Check that test results can still be uploaded via simple string key
  • Check that PartTestTemplate is created for test results which do not match a test template
  • Update CUI tables
  • Implement features for PUI table
  • Fix test fixture data
  • Remove old fields (test name) from StockItemTestResult model (with backwards data migration)
  • Validate admin integrations for PartTestTemplate and StockItemTestResult
  • Update demo dataset (more results, migrate data) - Test data demo-dataset#55
  • Update python bindings - Test result templates inventree-python#218
  • Update app - Support new test result API inventree-app#471

@SchrodingersGat SchrodingersGat added stock Related to Stock models user interface User interface Platform UI Related to the React based User Interface labels Feb 6, 2024
@SchrodingersGat SchrodingersGat added this to the 0.14.0 milestone Feb 6, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit fef628a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65d1d2974113c40008e8004b
😎 Deploy Preview https://deploy-preview-6430--inventree-web-pui-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat
Merge branch 'master' into test-result-table
6536e8b
@SchrodingersGat
Fix table link
ad6890e
@SchrodingersGat
Add option to filter parttesttemplate table by "inherited"
807a875
@SchrodingersGat
Navigate through to parent part
a72d02c
@SchrodingersGat
Update PartTestTemplate model
dc86142 
- Save 'key' value to database
- Update whenever model is saved
- Custom data migration
@SchrodingersGat
Custom migration step in tasks.py
10a7ba1 
- Add custom management command
- Wraps migration step in maintenance mode
@SchrodingersGat
Improve uniqueness validation for PartTestTemplate
bb2d90e
@SchrodingersGat
Add 'template' field to StockItemTestResult
f254d28 
- Links to a PartTestTemplate instance
- Add migrations to link existing PartTestTemplates
@SchrodingersGat
Add "results" count to PartTestTemplate API
045656c 
- Include in rendered tables
@SchrodingersGat
Add 'results' column to test result table
efef526 
- Allow filtering too
@SchrodingersGat
Update serializer for StockItemTestResult
1109fb3 
- Include template information
- Update CUI and PUI tables
@SchrodingersGat
Control template_detail field with query params
da2a3cb
@SchrodingersGat SchrodingersGat added the api Relates to the API label Feb 7, 2024
@SchrodingersGat SchrodingersGat added the enhancement This is an suggested enhancement or new feature label Feb 7, 2024
@SchrodingersGat
Update data migration
cf46f59 
- Ensure new template is created for top level assembly
@SchrodingersGat
Fix admin integration
33a3ce7
@SchrodingersGat
Update StockItemTestResult table
5b43ac1 
- Remove 'test' field
- Make 'template' field non-nullable
- Previous data migrations should have accounted for this
@SchrodingersGat
Implement "legacy" API support
e300534 
- Create test result by providing test name
- Lookup existing template
@SchrodingersGat SchrodingersGat added the breaking Indicates a major update or change which breaks compatibility label Feb 15, 2024
@SchrodingersGat SchrodingersGat mentioned this pull request Feb 18, 2024
Merged
@SchrodingersGat SchrodingersGat mentioned this pull request Feb 18, 2024
Open
@SchrodingersGat SchrodingersGat merged commit 0f51127 into inventree:master Feb 18, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the test-result-table branch February 18, 2024 12:26
@SchrodingersGat SchrodingersGat mentioned this pull request Feb 19, 2024
Merged
@SchrodingersGat SchrodingersGat added the migration Data or schema migrations label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Relates to the API breaking Indicates a major update or change which breaks compatibility enhancement This is an suggested enhancement or new feature migration Data or schema migrations Platform UI Related to the React based User Interface stock Related to Stock models user interface User interface
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SchrodingersGat